Open
Conversation
Member
|
LGTM |
This was referenced Mar 13, 2019
jrbourbeau
reviewed
Mar 20, 2019
Member
jrbourbeau
left a comment
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks for updating this @TomAugspurger!
I added two comments for updated documentation links. There are also a couple of things flake8 doesn't like. Otherwise LGTM
| .. _dask: http://dask.pydata.org/en/latest/ | ||
| .. _GLM: https://en.wikipedia.org/wiki/Generalized_linear_model | ||
| .. _scikit-learn: http://scikit-learn.org/ | ||
| .. _dask-ml: http://dask-ml.readthedocs.org/ |
Member
There was a problem hiding this comment.
Suggested change
| .. _dask-ml: http://dask-ml.readthedocs.org/ | |
| .. _dask-ml: https://ml.dask.org/ |
| @@ -30,3 +30,4 @@ Indices and tables | |||
| .. _dask: http://dask.pydata.org/en/latest/ | |||
Member
There was a problem hiding this comment.
Suggested change
| .. _dask: http://dask.pydata.org/en/latest/ | |
| .. _dask: https://docs.dask.org/ |
Member
Author
|
I won’t be able to update this in the near future. If anyone is able to push it through I’d appreciate it.
________________________________
From: James Bourbeau <notifications@github.com>
Sent: Wednesday, March 20, 2019 10:07 AM
To: dask/dask-glm
Cc: Tom Augspurger; Mention
Subject: Re: [dask/dask-glm] Deprecate estimators (#66)
@jrbourbeau commented on this pull request.
Thanks for updating this @TomAugspurger<https://github.com/TomAugspurger>!
I added two comments for updated documentation links. There are also a couple of things flake8 doesn't like. Otherwise LGTM
________________________________
In docs/index.rst<#66 (comment)>:
@@ -30,3 +30,4 @@ Indices and tables
.. _dask: http://dask.pydata.org/en/latest/
.. _GLM: https://en.wikipedia.org/wiki/Generalized_linear_model
.. _scikit-learn: http://scikit-learn.org/
+.. _dask-ml: http://dask-ml.readthedocs.org/
⬇️ Suggested change
-.. _dask-ml: http://dask-ml.readthedocs.org/
+.. _dask-ml: https://ml.dask.org/
________________________________
In docs/index.rst<#66 (comment)>:
@@ -30,3 +30,4 @@ Indices and tables
.. _dask: http://dask.pydata.org/en/latest/
⬇️ Suggested change
- .. _dask: http://dask.pydata.org/en/latest/
+.. _dask: https://docs.dask.org/
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#66 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABQHIuPtjqNTz7-pElHaZD4o-SiUbOd4ks5vYk6pgaJpZM4Qf2qr>.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #63
xref dask/dask-ml#94